New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Improvements to the Features and Messaging to the GC Infra re: ASP.NET Benchmarks #3293

Merged

cincuranet merged 27 commits into main from aspnet_improvements

Oct 14, 2023

Member

mrsharm commented Aug 23, 2023 •

edited

Loading

Fixed headers of commands and reporting results.
Improved the communication of failures and added documentation that delineates the reasons and troubleshooting steps.
Added the ability to specify additional arguments.
Added the ability to specify the framework version at the top and run level.
Early exit of analysis in case there is just one run.
Added the ability to upload either the entire folder or a specific file to crank.
Added the ability to specify the name of the run and benchmark if the log file is specified.
Added a notebook that's associated with analyzing results from the ASP.NET benchmarks.

mrsharm added 5 commits

August 23, 2023 12:49


          Added significant improvements to the ASP.NET Benchmarks

ac638f5


          Fixed up header for the analysis

de866ea


          Fix for the downloadOutputOutput field

049184a


          Cosmetic improvement and an example of the new params

f80211b


          Improved messaging from the analysis from

6bac308

mrsharm requested review from cshung, Maoni0 and markples

August 23, 2023 22:41

mrsharm added 4 commits

August 23, 2023 15:45


          The create suite command now should reference the entire folder rathe…

53ea22c

…r than a single corerun.exe


          Fixed linting issues

54a8b87


          One more Lint hydra fix

73dbf9f


          Fixed internal references in the markdown output

aa9ae69

markples reviewed

View reviewed changes

src/benchmarks/gc/GC.Infrastructure/Configurations/ASPNetBenchmarks/ASPNetBenchmarks.yaml Show resolved Hide resolved

markples reviewed

View reviewed changes

.../GC.Infrastructure/GC.Infrastructure.Core/CommandBuilders/ASPNetBenchmarks.CommandBuilder.cs Show resolved Hide resolved

markples reviewed

View reviewed changes

.../GC.Infrastructure/GC.Infrastructure.Core/CommandBuilders/ASPNetBenchmarks.CommandBuilder.cs Outdated Show resolved Hide resolved

markples reviewed

View reviewed changes

.../gc/GC.Infrastructure/GC.Infrastructure.Core/Configurations/ASPNetBenchmark.Configuration.cs Show resolved Hide resolved

markples reviewed

View reviewed changes

...Infrastructure/GC.Infrastructure/Commands/ASPNetBenchmarks/AspNetBenchmarksAnalyzeCommand.cs Show resolved Hide resolved

markples reviewed

View reviewed changes

...Infrastructure/GC.Infrastructure/Commands/ASPNetBenchmarks/AspNetBenchmarksAnalyzeCommand.cs Outdated Show resolved Hide resolved

markples reviewed

View reviewed changes

.../gc/GC.Infrastructure/GC.Infrastructure/Commands/ASPNetBenchmarks/AspNetBenchmarksCommand.cs Outdated Show resolved Hide resolved

markples reviewed

View reviewed changes

src/benchmarks/gc/GC.Infrastructure/docs/ASPNETBenchmarks.md Show resolved Hide resolved

mrsharm added 10 commits

August 28, 2023 13:40


          Added example of how to use the new config

8676f7a


          Addressed feedback and added contextually named log files if the vari…

6dee50c

…ables are specified


          Added the name of the file and the log file extension

509b410


          Added the analysis notebook

35b4351


          Adjusted the csv files to be without spaces and modified the Linux an…

d4f29d8

…d Generic runs


          Updated README to reflect changes

fbf44c4


          Updated documentation

17aec7d


          Fixed md liniting issues

9816c4d


          Fixed up the notebook to work for both windows and linux

8e960ed


          Continued work on improving the usability of the analysis

9d573d2

mrsharm added 3 commits

September 11, 2023 19:47


          Merge remote-tracking branch 'origin' into aspnet_improvements

5e9b3a2


          Added fix for certain cases where the log wasn't being downloaded

809b534


          implemented the volatility and difference comparisons

8bf7c48

Member

Maoni0 commented Sep 13, 2023

{

let's not checkin the output of the notebooks.

Refers to: src/benchmarks/gc/GC.Infrastructure/Notebooks/ASPNetBenchmarkAnalysis.ipynb:1 in 8bf7c48. [](commit_id = 8bf7c48, deletion_comment = False)

Maoni0 previously approved these changes

View reviewed changes

Member

Maoni0 left a comment

aside from the output, rest LGTM


          Incorporated feedback, detection if the process timed out and noteboo…

a0047ba

…k improvements

mrsharm dismissed Maoni0’s stale review via

a0047ba

September 15, 2023 03:59

mrsharm added 4 commits

September 15, 2023 00:44


          Cleared output

f57042a


          Updated plot for vol

7a95f42


          Added benchmark filtering and fix path in the notebook

ba8c7e0


          Ordering in terms of filters and matches on ends + regexes

82ef8a4

Maoni0 approved these changes

View reviewed changes

Member Author

mrsharm commented Oct 13, 2023

@cincuranet - can we please merge this? Thanks in advance!

Maoni0 enabled auto-merge (squash)

October 13, 2023 23:07

Maoni0 disabled auto-merge

October 13, 2023 23:08

cincuranet merged commit 74c994b into main

23 of 31 checks passed

LoopedBard3 deleted the aspnet_improvements branch

March 11, 2024 20:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet